fix(release): include sdk in fixed-version bump#1363
Open
kiyeonjeon21 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/sdkin the fixed-version release package listNotes
I noticed
@hyperframes/sdkis already part of the workspace build/test path, but the release helper did not includepackages/sdkin the fixed-version package list. With the current helper, running a release bump leaves the SDK package version behind while the rest of the workspace advances.This intentionally does not add
@hyperframes/sdkto the publish workflow. Publishing the SDK seems like a separate maintainer decision; this PR only keeps its package metadata aligned with the repo's fixed-version release tooling.Testing
bun run test:scriptsbunx oxfmt --check scripts/set-version.ts scripts/set-version.test.ts packages/sdk/package.jsonbunx oxlint scripts/set-version.ts scripts/set-version.test.tsbun install --frozen-lockfilebun run set-version 0.6.92 --no-tag --skip-changelog-check --skip-monotonicity-checkbumps@hyperframes/sdkwith the rest of the workspace