Skip to content

fix(studio): remove unused onSelectElementById after indicator removal #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguel-heygen merged 1 commit into from
Jun 12, 2026
+0 −12
Merged

fix(studio): remove unused onSelectElementById after indicator removal #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/studio/src/components/StudioPreviewArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ export function StudioPreviewArea({
handlePreviewCanvasPointerMove,
handlePreviewCanvasPointerLeave,
applyDomSelection,
buildDomSelectionFromTarget,
handleBlockedDomMove,
handleDomManualDragStart,
handleDomPathOffsetCommit,
Expand Down Expand Up @@ -291,14 +290,6 @@ export function StudioPreviewArea({
onRotationCommit={handleDomRotationCommit}
gridVisible={snapPrefs.gridVisible}
gridSpacing={snapPrefs.gridSpacing}
onSelectElementById={async (id) => {
const iframe = previewIframeRef.current;
const el = iframe?.contentDocument?.getElementById(id);
if (!el) return null;
const sel = await buildDomSelectionFromTarget(el);
if (sel) applyDomSelection(sel, { revealPanel: true });
return sel;
}}
/>
<SnapToolbar onSnapChange={setSnapPrefs} />
{gestureOverlay}
Expand Down
3 changes: 0 additions & 3 deletions packages/studio/src/components/editor/DomEditOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ interface DomEditOverlayProps {
) => void;
onBlockedMove: (selection: DomEditSelection) => void;
onManualDragStart?: () => void;
onSelectElementById?: (id: string) => Promise<DomEditSelection | null>;
onPathOffsetCommit: (
selection: DomEditSelection,
next: { x: number; y: number },
Expand Down Expand Up @@ -84,7 +83,6 @@ export const DomEditOverlay = memo(function DomEditOverlay({
gridVisible = false,
gridSpacing = 50,
onManualDragStart,
onSelectElementById,
onPathOffsetCommit,
onGroupPathOffsetCommit,
onBoxSizeCommit,
Expand Down Expand Up @@ -214,7 +212,6 @@ export const DomEditOverlay = memo(function DomEditOverlay({
return () => cancelAnimationFrame(frame);
});


const gestures = createDomEditOverlayGestureHandlers({
overlayRef,
iframeRef,
Expand Down
Loading