fix(registry): add missing vscode-theme-visualizer to registry.json#1503
Open
Dashsoap wants to merge 1 commit into
Open
fix(registry): add missing vscode-theme-visualizer to registry.json#1503Dashsoap wants to merge 1 commit into
Dashsoap wants to merge 1 commit into
Conversation
miguel-heygen
approved these changes
Jun 16, 2026
Collaborator
|
@Dashsoap sign the commit to merge it pls |
The vscode-theme-visualizer example ships a complete registry/examples/vscode-theme-visualizer/registry-item.json (added in v0.6.104) but was never added to the auto-generated top-level registry/registry.json. The CLI resolver only knows items listed in registry.json, so `hyperframes add vscode-theme-visualizer` fails with "not found in registry" even though the item is fully present on disk. This is exactly the output of re-running scripts/generate-registry-items.ts (its scanExistingItems() fallback picks up every example dir that has a registry-item.json), so the manifest is now back in sync with the 9 example dirs on disk.
5d11e30 to
2775573
Compare
Author
|
Done — the commit is now signed and shows as Verified. Ready to merge whenever you get a chance. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the missing
vscode-theme-visualizerentry to the auto-generated top-levelregistry/registry.json.Why
The
vscode-theme-visualizerexample ships a complete manifest atregistry/examples/vscode-theme-visualizer/registry-item.json(added in v0.6.104), along with itsindex.html,DESIGN.md,assets/,render-entries/, andscripts/. But it was never added toregistry/registry.json.The CLI resolver only knows about items listed in the top-level manifest —
resolveItemWithDependencies()inpackages/cli/src/registry/resolver.tsdoesentries.find((e) => e.name === name)and throwsItem "..." not found in registrywhen there's no match. Sohyperframes add vscode-theme-visualizerfails even though the item is fully present on disk.All 9 example directories that carry a
registry-item.jsonshould appear inregistry.json; before this change only 8 did:How
Added the one missing entry in the example block, right after
nyt-graph:{ "name": "vscode-theme-visualizer", "type": "hyperframes:example" },This is exactly what re-running
scripts/generate-registry-items.tsproduces — itsscanExistingItems()fallback picks up every example dir that has aregistry-item.json, so the hand-applied entry matches the generator output and the manifest is back in sync (9/9).Test plan
JSON.parsesucceeds, item count 130 → 131, and the manifest'shyperframes:exampleset now exactly equals the set of example dirs that have aregistry-item.json(was 8/9, now 9/9). Verified the entry matches whatgenerate-registry-items.tswould emit.