Conversation
hgaiser
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit “sRGB → BT.2020 + PQ” conversion mode to the GPU color converter so SDR (sRGB-encoded) content can be encoded into an HDR (BT.2020/PQ) stream.
Changes:
- Adds a new
ColorSpace::SrgbToBt2020Pqvariant and aset_color_space()setter onColorConverter. - Extends the compute shader with sRGB inverse EOTF, BT.709→BT.2020 gamut mapping, and PQ OETF for the new mode.
- Adjusts BT.2020 coefficient selection to also cover the new mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/converter/shader.rs |
Adds sRGB→linear, BT.709→BT.2020 matrix, and PQ encoding path in read_rgb(); updates BT.2020 selection logic. |
src/converter/mod.rs |
Adds new ColorSpace variant and a runtime set_color_space() API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.