Skip to content

Doesn't paint lines for the first and last points properly.#10

Open
jktu2870 wants to merge 1 commit intohgoebl:masterfrom
jktu2870:master
Open

Doesn't paint lines for the first and last points properly.#10
jktu2870 wants to merge 1 commit intohgoebl:masterfrom
jktu2870:master

Conversation

@jktu2870
Copy link
Copy Markdown

@jktu2870 jktu2870 commented Mar 2, 2018

  • If the first few points have the same "fnContext" result (0 for example), they will be painted in the color of the first point which has a different result (1 for example).
  • The mainline ends with the color of a penultimate point (not last).

@jktu2870 jktu2870 closed this Mar 3, 2018
@hgoebl
Copy link
Copy Markdown
Owner

hgoebl commented Mar 4, 2018

Hi @jktu2870
can you tell me please why you already closed this PR?
I had a short view of the code and it looks good to me, though I haven't tested it.

@jktu2870
Copy link
Copy Markdown
Author

jktu2870 commented Mar 5, 2018 •
edited
Loading

Hi @hgoebl
It's nice to know you estimated my PR as good. I closed PR because I have doubt about performance since "fnContext" now cause twice per iteration. Also, I didn't test this solution for every case MultiOptionsPolyline can be used for, only for examples on the demo page and for my specific task.
I'll reopen PR, if you have time to test it then it would be great.

@jktu2870 jktu2870 reopened this Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jktu2870 @hgoebl