Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the package around the actual product surface: benchmark data loaders, feature-driven simulation, and learning statistics.
It removes
mreffrom the core learning-model and dataset-loading paths, flattens the linear learner implementation, and makes local data caching explicit and repo-local by default.What Changed
LinearLearnerintohobj.learning_modelsand moved representation/update-rule modules to top-levelhobj.learning_models.ImageIdtyping inhobj/types.py.mreffrom learning-model code and tests.hobj.data_loaders.imagesand removed the oldhobj.data.imagespath.Imagesetso it:cachedir: Path | None = Nonedata/default_data_storeImageId/Pathinstead ofImageRefhobj/data_loaders/behavior.pyto cache downloaded JSON locally withoutdefault_data_store.uvin.github/workflows/ci.ymland addeduv.lock.pyproject.toml.Why
The previous design exposed infrastructure abstractions like
mref,ImageRef, and a global data store in places where the library really only needs:This PR narrows the API around those real needs and reduces coupling across the package.
Impact
mrefis no longer part of the core learning-model / data-loader workflow.hobj.data...image modules will need to switch tohobj.data_loaders....data/in the repo rather than the previous global cache/store path.Validation
uv run pytest -q4 passed