Rework docker setup#1
Open
norpol wants to merge 5 commits intohisptoot:mainfrom
Open
Conversation
Owner
|
Thank you for the improvements. I will check the code and merge your code after I finish the config file generation function. |
Author
|
Thanks for checking it out, please leave some review and let me know if you're happy with the direction. I'm happy to rebase/test everything once you've figured out the #2 solution. I thought maybe adding some WebUI might be cool extension (might be needed anyway if we are doing the oauth-login procedure that the BambuStudio does). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, incredible big thank you for this code. I'm a total C/C++ noob and didn't realize it was that easily possible.
I think there might be some cool ideas possible with this project.
I've managed to get a stream running, for this I've decided to rework Dockerfile and some of the scripts. Although I'm happy to add some of the functionality back. See this pull request as a first draft of a clearer setup. I'm also going to add GitHub action for the docker building maybe.
Anyhow.
builderstep that runs make itselfmake dockerand some of the copying stagesoutdirisn't needed in each commandoutdiroverrideable by using?=instead of=I can doexport outdir="dir"since../would have been a bit messy inside theDockerfileI'm seeing this as a first draft, as I don't know how many changes/which changes you like to get. I'll adjust anything regarding your feedback.