fix(lint): clippy -D warnings の既存違反を解消#17
Merged
Merged
Conversation
CI の cargo clippy --all-targets -- -D warnings が main で落ちていた （#574 由来ではない既存違反）。 - db.rs: load_chat_messages の if let Ok を rows.flatten() に (manual_flatten) - models.rs: assert_eq!(_, bool) を assert!/assert!(!_) に (bool_assert_comparison)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
CI の
cargo clippy --all-targets -- -D warningsが main で失敗していた。これらは #574 (muted_user_ids) 由来ではなく、以前から存在した clippy 違反が-D warningsで顕在化したもの。main を green に戻し、後続 PR をブロックしないようにする。何を
db.rsload_chat_messages:for row in rows { if let Ok(m) = row {...} }→for m in rows.flatten()(clippy::manual_flatten)models.rsテスト:assert_eq!(x, true)/assert_eq!(x, false)→assert!(x)/assert!(!x)(clippy::bool_assert_comparison)挙動は不変。
cargo clippy --all-targets -- -D warningsとcargo test(152 passed) green を確認。🤖 Generated with Claude Code