glibc backcompatiblity#8
Merged
Merged
Conversation
hiverge-robot
added
needs-triage
Contributor
Author
|
/kind enhacnement |
There was a problem hiding this comment.
Pull request overview
This PR updates the binary build process to improve Linux glibc compatibility by switching the build container/toolchain, and adjusts main.py typing behavior to remain importable under older Python versions used during bundling.
Changes:
- Add
from __future__ import annotationsand remove unusedsysimport inmain.py. - Switch the PyInstaller build container from
python:3.11-slimtoquay.io/pypa/manylinux2014_x86_64, and update dependency installation steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
main.py |
Enables postponed evaluation of annotations (helps if bundling under older Python), and removes an unused import. |
build-binary.sh |
Moves the build into a manylinux2014 environment to target an older glibc baseline, and adjusts Python/dependency setup for the build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+31
to
39
| echo 'Installing Python 3.8 (shared) and build deps...' && \ | ||
| yum -y -q --disablerepo='epel*' install rh-python38-python-devel && \ | ||
| source /opt/rh/rh-python38/enable && \ | ||
| python3 -m ensurepip --upgrade && \ | ||
| python3 -m pip install -q --upgrade pip && \ | ||
| python3 -m pip install -q pyinstaller flask requests psutil waitress python-json-logger 'urllib3<2' && \ | ||
| echo 'Running PyInstaller...' && \ | ||
| pyinstaller daemon-server.spec && \ | ||
| echo 'Build complete!' |
| apt-get update -qq && \ | ||
| apt-get install -y -qq binutils && \ | ||
| pip install -q pyinstaller flask requests psutil waitress python-json-logger && \ | ||
| quay.io/pypa/manylinux2014_x86_64 bash -c " |
luc-hiverge
approved these changes
Jul 10, 2026
| @@ -1,10 +1,11 @@ | |||
| """A simple Python sandbox server that executes Python functions.""" | |||
|
|
|||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Is this important? If yes maybe comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New binary built (allegedly) supports versions of
glibcup to>=2.14. For reference, the previous binary only support>=2.38), and, e.g.,ubuntu:22.04: needs glibc 2.35ubuntu:20.04: needs glibc 2.31 (tested)debian:12: needs glibc 2.36