Skip to content

Allow prompting context/ideas to be specified in hive.yaml#84

Merged
hiverge-robot merged 3 commits into
mainfrom
prompt-config
Dec 9, 2025
Merged

Allow prompting context/ideas to be specified in hive.yaml#84
hiverge-robot merged 3 commits into
mainfrom
prompt-config

Conversation

@kerry-hiverge

@kerry-hiverge kerry-hiverge commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

@hiverge-robot hiverge-robot added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2025
@kerry-hiverge

Copy link
Copy Markdown
Contributor Author

/kind cleanup

@hiverge-robot hiverge-robot added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Dec 6, 2025
Comment thread src/hive_cli/config.py Outdated
description="Sandbox configuration for the experiment.",
)
prompt: Optional[PromptConfig] = None
prompt: PromptConfig = Field(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is prompt a must-have?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, changed to optional.

Comment thread src/hive_cli/config.py Outdated
class PromptConfig(BaseModel):
enable_evolution: bool = False
context: str = Field(
default="",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default to "" is confusion, can we make it optional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now changed to an optional argument

@ky-hiverge

Copy link
Copy Markdown
Member

/lgtm
/approve
/kind feature

@hiverge-robot hiverge-robot added lgtm Looks good to me, indicates that a PR is ready to be merged. feature Categorizes issue or PR as related to a new feature. labels Dec 9, 2025
@hiverge-robot hiverge-robot merged commit e065b98 into main Dec 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants