fix: racy double creation of docker tag#92
Merged
Conversation
The documentation of `--load` says it's for single platform builds.
These are never single-platform builds.
https://docs.docker.com/reference/cli/docker/buildx/build/#load
Therefore, we can just remove `--load`.
Contributor
Author
|
/kind fix |
Contributor
Author
|
/kind bug |
Member
|
/lgtm I add this for some reason before, but forgot it. Merge for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running:
I frequently run into the following error:
The documentation claims that
--loadis only valid for single-platform builds. Since, we're doing multi-platform build, I suspect this flag might be invalid.Removing
--loadis highly effective at stopping the issue, especially in the version shown in the first commit. The second version I've run a few times and is too succeeds (but it's identical to the previous version in my setup).