Fix start script to use uv to install dev dependency group#93
Merged
Conversation
hiverge-robot
added
needs-triage
Contributor
Author
|
/kind bug |
hiverge-robot
added
bug
Contributor
Author
|
@ky-hiverge Could you take a look at this tiny PR when you get a chance please? |
Member
|
/lgtm |
hiverge-robot
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the start.sh script to use
uv syncinstead ofpip installto install thedevdependency group.I think this was broken by the change from
project.optional-dependenciestodependency-groupsin this commit. AFAIK pip does not supportdependency-groupsso we need to use uv instead.