feat: make building the docker image configurable.#94
Merged
Conversation
This commit adds a new top-level section to the experiment config:
docker:
dockerfile: exp1/Dockerfile
verbose: true
which enables the user to pick the Dockerfile for the baseimage of the
sandbox. It also allows making the build-process verbose, i.e.
`--process=plain`.
Contributor
Author
|
This allows me to create an "overlay" style setup: where the source code to be optimized lives in Then I can create different experiments like this: Then the dockerfiles do: (the overlay system). Then I launch experiments as follows: |
Contributor
|
/lgtm |
Contributor
|
/kind feature |
Contributor
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new top-level section to the experiment config:
which enables the user to pick the Dockerfile for the baseimage of the sandbox. It also allows making the build-process verbose, i.e.
--process=plain.