Skip to content

Preliminary Lifter Scoped Support #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LPTK merged 4 commits into from
Dec 30, 2025
Merged

Preliminary Lifter Scoped Support #373

LPTK merged 4 commits into from
Dec 30, 2025

Conversation

@CAG2Mark
Copy link
Contributor

@CAG2Mark CAG2Mark commented Dec 30, 2025

Preliminary lifter support for scoped blocks. The full revamp is still ongoing.

@CAG2Mark
Copy link
Contributor Author

CAG2Mark commented Dec 30, 2025 •
edited
Loading

We really need to address those HashMap/HashSet symbol order changes...

@LPTK
Copy link
Contributor

LPTK commented Dec 30, 2025

We really need to address those HashMap/HashSet symbol order changes...

Actually, we don't really. We're only seeing changes here because there are unexpected compilation errors, which triggers the printing of internal Scope data structures. In principle, we should not be committing that, or at least not making PRs with such changes.

The printing of Scoped, on the other hand, was already handled by b6593ed.

@CAG2Mark
Copy link
Contributor Author

CAG2Mark commented Dec 30, 2025 •
edited
Loading

BTW should be ready.

Some of the tests fail because the handler fixes are not yet merged

@LPTK
Copy link
Contributor

LPTK commented Dec 30, 2025

(I guess it wouldn't be too bad to adapt the printing of Scope in a way similar to how the printing of Scoped was handled, as it would avoid needless changes in abnormal PRs like this one.)

LPTK
LPTK approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thx.

@LPTK LPTK merged commit 6bf210f into hkust-taco:remove-scope-hacks Dec 30, 2025
1 check failed
@LPTK LPTK deleted the lifter-temp-fix branch December 30, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnsonYeung AnsonYeung AnsonYeung left review comments

@LPTK LPTK LPTK approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CAG2Mark @LPTK @AnsonYeung