Open
Fix DkCoreProfessionGroupCodes: resolve non-unique code 5176, sync with current autorisationsregister#225
Conversation
Copilot
AI
changed the title
[WIP] Fix missing uniqueness in profession group in AutoristationsRegister
Fix DkCoreProfessionGroupCodes: resolve non-unique code 5176, sync with current autorisationsregister
Jul 17, 2026
jkiddo
marked this pull request as ready for review
July 17, 2026 14:13
jkiddo
approved these changes
Jul 17, 2026
christiangasser-lakeside
left a comment
christiangasser-lakeside
left a comment
Collaborator
There was a problem hiding this comment.
No other comments :-)
| Id: DkCoreProfessionGroupCodes | ||
| Title: "DK Profession Group Codes" | ||
| Description: "DK health ProfessionGroup codes as defined by https://www.retsinformation.dk/eli/lta/2019/731, and derived from http://autregwebservice.sst.dk/autregservice.asmx/GetAllProfessionGroups. Code (5176) was not uniqe, and have been converted to 5176a and 5176b" | ||
| Description: "DK health ProfessionGroup codes as defined by https://www.retsinformation.dk/eli/lta/2019/731, and derived from https://autregwebservice.stps.dk/autregservice.asmx/GetAllProfessionGroups" |
Collaborator
There was a problem hiding this comment.
Update retsinformation to latest: https://www.retsinformation.dk/eli/lta/2024/1008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code
5176inDkCoreProfessionGroupCodeswas non-unique in the autorisationsregister — it mapped to both "Kontaktlinseoptiker" and "Optometrist". A previous workaround introduced artificial codes5176a/5176b. The upstream register (now atautregwebservice.stps.dk) has since been corrected, making the workaround obsolete.Changes to
input/fsh/codeSystems.fsh#5176a "Kontaktlinseoptiker"and#5176b "Optometrist"— no longer present in the register#4498from"Optiker"to"Optiker og Optometrist"— profession group was merged upstream#7150 "Psykolog"— new entry in the current register^countfrom21→20autregwebservice.sst.dktoautregwebservice.stps.dk