Skip to content

Conversation

@Chooks22
Copy link
Contributor

Fixed some fields mentioned in #88

@Chooks22 Chooks22 requested a review from sphinxrave February 12, 2021 13:31
@Chooks22 Chooks22 linked an issue Feb 12, 2021 that may be closed by this pull request
Comment on lines +51 to +52
status:
type: string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
status:
type: string
status:
type: string
enum: ['past', 'live', 'upcoming', 'missing', 'new']

Add possible values, makes it easier to work with the API
Don't think example would be appropiate here.

Comment on lines +73 to +74
published_at:
type: string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
published_at:
type: string
published_at:
type: string
format: date-time

Add a format as specified here: Data types
Could be useful, though not really important. If it gets changed here, everywhere else should be changed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mistakes in the documentation

2 participants