Dockerfile add patch bump telldus minimum CMake to 3.10.0#405
Conversation
|
I wonder if we could make Probably not worth the effort, according to analytics only 111 users of the TellStick integration. But also might still be in use, so not (yet) ready to be killed off 😢 . |
|
@agners We could also drop the integration if it needs system packages. After the big arch and core deprecation I removed a lot integration that relied on system packages. I looked only at core but if telldus is not used by any core component and just a single integration, we could drop it similar to the others. |
|
@edenhaus if removal of telldus is the consensus then I agree close WONTFIX this particular PR #405, my concern is resolved when the source of the build failure is resolved. I have no particular interest in telldus and am not in need of it, nor do I have an interest in assuming a maintainer role e.g. forking and formally addressing the unmaintained status. Likewise feel free if you think appropriate to apply this PR with an announcement for the removal of this software in the next release, which may give any potential users of this software some opportunity to take action. |
|
It was just an idea not that we should do it. We just don't allow anymore new integrations that require system packages due maintainability and co. |
|
@agners writes:
It should not break anything to apply this patch as-is to resolve the build warnings in cmake versions we are using now before any introduction of alpine 3.23 I'm just agreeable if you want to kill this patch and the integration, or amend it with a warning about any pending action to kill/migrate the integration, fine with me. I would like to see this patch applied though in any event to resolve the existing warnings and to make a version bump to alpine 3.23 buildable for testing. |
Bump minimum CMake from 2.4.0 or 2.6 to 3.10.0 as required by Alpine 3.23
cae91e8 to
166d124
Compare
|
rebased on master |
Compatibility for CMake versions older than 3.10 is deprecated with previous CMake version 3.31 as distributed with Alpine 3.21 and backwards compatibility for CMake older than 3.5 by overrides and feature flags is now removed. Let's bump the minimum CMake in telldus by patch from 2.4.0 or 2.6 to 3.10.0 as required by CMake 4.0 introduced to Home Assistant CI/CD with Alpine 3.23