Skip to content

Dockerfile add patch bump telldus minimum CMake to 3.10.0#405

Open
eshattow wants to merge 1 commit into
home-assistant:masterfrom
eshattow:patch-telldus-bump-cmake-mrv-3100
Open

Dockerfile add patch bump telldus minimum CMake to 3.10.0#405
eshattow wants to merge 1 commit into
home-assistant:masterfrom
eshattow:patch-telldus-bump-cmake-mrv-3100

Conversation

@eshattow

Copy link
Copy Markdown

Compatibility for CMake versions older than 3.10 is deprecated with previous CMake version 3.31 as distributed with Alpine 3.21 and backwards compatibility for CMake older than 3.5 by overrides and feature flags is now removed. Let's bump the minimum CMake in telldus by patch from 2.4.0 or 2.6 to 3.10.0 as required by CMake 4.0 introduced to Home Assistant CI/CD with Alpine 3.23

@agners

agners commented Apr 28, 2026

Copy link
Copy Markdown
Member

I wonder if we could make tellcore-py a wheel with the native library integrated, so we don't have to install it as part of the base container any longer? 🤔

Probably not worth the effort, according to analytics only 111 users of the TellStick integration. But also might still be in use, so not (yet) ready to be killed off 😢 .

@edenhaus

Copy link
Copy Markdown
Member

@agners We could also drop the integration if it needs system packages. After the big arch and core deprecation I removed a lot integration that relied on system packages. I looked only at core but if telldus is not used by any core component and just a single integration, we could drop it similar to the others.

@eshattow

Copy link
Copy Markdown
Author

@edenhaus if removal of telldus is the consensus then I agree close WONTFIX this particular PR #405, my concern is resolved when the source of the build failure is resolved. I have no particular interest in telldus and am not in need of it, nor do I have an interest in assuming a maintainer role e.g. forking and formally addressing the unmaintained status. Likewise feel free if you think appropriate to apply this PR with an announcement for the removal of this software in the next release, which may give any potential users of this software some opportunity to take action.

@edenhaus

Copy link
Copy Markdown
Member

It was just an idea not that we should do it. We just don't allow anymore new integrations that require system packages due maintainability and co.

@eshattow

eshattow commented Jun 8, 2026

Copy link
Copy Markdown
Author

@agners writes:

...
Probably not worth the effort, according to analytics only 111 users of the TellStick integration. But also might still be in use, so not (yet) ready to be killed off 😢 .

It should not break anything to apply this patch as-is to resolve the build warnings in cmake versions we are using now before any introduction of alpine 3.23

I'm just agreeable if you want to kill this patch and the integration, or amend it with a warning about any pending action to kill/migrate the integration, fine with me. I would like to see this patch applied though in any event to resolve the existing warnings and to make a version bump to alpine 3.23 buildable for testing.

Bump minimum CMake from 2.4.0 or 2.6 to 3.10.0 as required by Alpine 3.23
@eshattow eshattow force-pushed the patch-telldus-bump-cmake-mrv-3100 branch from cae91e8 to 166d124 Compare June 8, 2026 03:25
@eshattow

eshattow commented Jun 8, 2026

Copy link
Copy Markdown
Author

rebased on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants