Fix False Positive and Change Fungus1_26[left1]#83
Open
qwint wants to merge 1 commit into
Open
Conversation
…a more specific and restricted itemset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently this can be in logic without left cdash (as RIGHTACIDSKIP requires right cdash) so this is a false positive
fixes the cdash direction and also updates the clause to drop the macro for a more specific and restricted itemset
there also may be an argument that COMPLEXSKIPS should still apply to this route (similar example but using a shade instead of shrogos https://youtu.be/M82I0vQ_0MA?is=Z9RdUMR2eIJ5nibs), but if that option gets added (and leftdash does not get removed like i have done here), this clause is strictly inferior to the other clause
example of the clause: Fungus1_26_left1_underpier.webm