Skip to content

Comments

feat(node-ws): Environment variable support#1733

Open
PeterZhenhh wants to merge 7 commits intohonojs:mainfrom
PeterZhenhh:fix-node-ws-env
Open

feat(node-ws): Environment variable support#1733
PeterZhenhh wants to merge 7 commits intohonojs:mainfrom
PeterZhenhh:fix-node-ws-env

Conversation

@PeterZhenhh
Copy link

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

All tests pass locally.

const { injectWebSocket, upgradeWebSocket } = createNodeWebSocket({ app, env })

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

🦋 Changeset detected

Latest commit: bf59dbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/node-ws Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.68%. Comparing base (274cf1e) to head (bf59dbf).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1733   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files         112      112           
  Lines        3733     3734    +1     
  Branches      946      947    +1     
=======================================
+ Hits         3460     3461    +1     
  Misses        245      245           
  Partials       28       28           
Flag Coverage Δ
node-ws 81.11% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe
Copy link
Member

Hey @nakasyou

Can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants