feat(node-ws): Environment variable support#1733
Open
PeterZhenhh wants to merge 7 commits intohonojs:mainfrom
Open
feat(node-ws): Environment variable support#1733PeterZhenhh wants to merge 7 commits intohonojs:mainfrom
PeterZhenhh wants to merge 7 commits intohonojs:mainfrom
Conversation
Added environment variable handling in WebSocket tests.
🦋 Changeset detectedLatest commit: bf59dbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 112 112
Lines 3733 3734 +1
Branches 946 947 +1
=======================================
+ Hits 3460 3461 +1
Misses 245 245
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yusukebe
reviewed
Feb 10, 2026
Member
|
Hey @nakasyou Can you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
yarn changesetat the top of this repo and push the changesetAll tests pass locally.