Skip to content

fix(mcp): remove trailing slash from issuer URL in OAuth metadata#1760

Open
MathurAditya724 wants to merge 3 commits intohonojs:mainfrom
MathurAditya724:patch-5
Open

fix(mcp): remove trailing slash from issuer URL in OAuth metadata#1760
MathurAditya724 wants to merge 3 commits intohonojs:mainfrom
MathurAditya724:patch-5

Conversation

@MathurAditya724
Copy link
Contributor

Closes #1753

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2026

🦋 Changeset detected

Latest commit: b3c5a5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/mcp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.71%. Comparing base (8a0d4ea) to head (b3c5a5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1760   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         113      113           
  Lines        3778     3779    +1     
  Branches      954      956    +2     
=======================================
+ Hits         3465     3466    +1     
  Misses        281      281           
  Partials       32       32           
Flag Coverage Δ
mcp 90.52% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe
Copy link
Member

@MathurAditya724 If it's ready to review, please ping me!

@MathurAditya724 MathurAditya724 marked this pull request as ready for review February 24, 2026 18:44
@MathurAditya724
Copy link
Contributor Author

it's ready for review @yusukebe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

createOAuthMetadata forces trailing slash in issuer (cannot represent exact external issuer in authorization_servers)

2 participants