Skip to content

docs(oidc-auth): Clarify some docs regarding oidc-auth#1761

Merged
yusukebe merged 3 commits intohonojs:mainfrom
andrewhong04:clarify-https-vs-http
Feb 27, 2026
Merged

docs(oidc-auth): Clarify some docs regarding oidc-auth#1761
yusukebe merged 3 commits intohonojs:mainfrom
andrewhong04:clarify-https-vs-http

Conversation

@andrewhong04
Copy link
Contributor

I ran into some problems during development that took a bit of time to workaround. There's nothing wrong with the code but I think this will save future developers a lot of time.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2026

⚠️ No Changeset found

Latest commit: b4b07af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.71%. Comparing base (8a0d4ea) to head (b4b07af).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1761   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         113      113           
  Lines        3778     3778           
  Branches      954      954           
=======================================
  Hits         3465     3465           
  Misses        281      281           
  Partials       32       32           
Flag Coverage Δ
oidc-auth 96.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrewhong04
Copy link
Contributor Author

Hi @yusukebe, just checking in on if this meets the repository's standards.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@adjsky Thanks!

@yusukebe yusukebe changed the title Clarify some docs regarding oidc-auth docs(oidc-auth): Clarify some docs regarding oidc-auth Feb 27, 2026
@yusukebe yusukebe merged commit e549c57 into honojs:main Feb 27, 2026
91 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants