Skip to content

Fix: Incorrect Config with custom middleware #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmol-fzr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Incorrect Config with custom middleware #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/middleware/builtin/cors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ If you want to adjust CORS configuration according to the execution environment,
```ts
app.use('*', async (c, next) => {
const corsMiddlewareHandler = cors({
origin: c.env.CORS_ORIGIN,
origin: [c.env.CORS_ORIGIN],
Copy link
Member

@yusukebe yusukebe Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the origin option can accept a string. So this change is unnecessary.

Copy link
Member

@yusukebe yusukebe Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on whether the CORS_ORIGIN is a string or string[]. But I think this change is unnecessary.

})
return corsMiddlewareHandler(c, next)
})
Expand Down