Skip to content

Conversation

@amulet1
Copy link
Contributor

@amulet1 amulet1 commented Jul 8, 2025

To utilize it we just need to rename Horde_Core_Ui_VarRenderer_* classes in other apps (except Core).

For example, in Turba app class Horde_Core_Ui_VarRenderer_Turba should be renamed to Turba_Core_Ui_VarRenderer_Turba.

To provide a seamless transition a fallback to the original loading method is implemented. Once it is done, it can be removed:

// TODO: Eliminate after renaming Horde_Ui_VarRenderer_* classes in other apps to {app}_Ui_VarRenderer_*
if (!$ok && !empty($app)) {
    // fallback to legacy method (manual load)
    $class = __CLASS__ . '_' . $driver;
    include_once $GLOBALS['registry']->get('fileroot', $app) . '/lib/Ui/VarRenderer/' . $driver . '.php';
    $ok = class_exists($class);
}

Fallback to original loading method if class is not autoloaded.
@amulet1
Copy link
Contributor Author

amulet1 commented Jul 8, 2025

@ralflang, please merge.

@amulet1
Copy link
Contributor Author

amulet1 commented Aug 6, 2025

@TDannhauer, please could you review/merge?

Copy link
Contributor

@TDannhauer TDannhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI supported, human reviewed and tested in deployment. looks good for me. Adaptions in apps are handled separately, fallback allows transition.

@TDannhauer TDannhauer merged commit 55d860f into horde:FRAMEWORK_6_0 Nov 29, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants