ci(workflows): use host-uk/build@dev for releases #264
Conversation
- Replace manual Go bootstrap with host-uk/build@dev action - Add matrix builds for linux/amd64, linux/arm64, darwin/universal, windows/amd64 - Update README URLs from Snider/Core to host-uk/core - Simplify artifact handling with merge-multiple Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughGitHub Actions workflows refactored to use a matrix strategy for multi-platform builds and consolidated build steps into a single Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHubActions as GH Actions (matrix runner)
participant BuildAction as host-uk/build@dev
participant Artifacts as Actions Artifacts
participant ReleaseJob as Release Job
Developer->>GitHubActions: push / tag triggers workflow
GitHubActions->>BuildAction: run matrix jobs (platform param)
BuildAction->>Artifacts: upload dist/* artifacts
GitHubActions->>ReleaseJob: trigger release job after matrix completes
ReleaseJob->>Artifacts: download (merge-multiple: true)
ReleaseJob->>ReleaseJob: copy dist/* -> release/
ReleaseJob->>Developer: create GitHub release with assets
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/release.yml:
- Around line 28-35: The Build step currently pins the action to the unstable
ref host-uk/build@dev; change that to a stable tag or commit SHA (e.g.,
host-uk/build@vX.Y.Z or host-uk/build@<commit-sha>) so production releases use
an immutable, tested action; update the uses value in the step named "Build"
accordingly and, if relevant, document or source the chosen tag so future
updates are intentional.
🧹 Nitpick comments (2)
.github/workflows/dev-release.yml (1)
55-55: Silent failure on artifact copy could mask build issues.The
2>/dev/null || truepattern suppresses all errors, which could hide problems if the build action fails to produce artifacts or outputs them to an unexpected location.Consider logging the contents of
dist/before copying, or removing the error suppression to surface issues:Suggested improvement
- name: Prepare release files run: | mkdir -p release + echo "Contents of dist/:" + ls -la dist/ || echo "dist/ is empty or does not exist" - cp dist/* release/ 2>/dev/null || true + cp dist/* release/ || echo "Warning: No files to copy from dist/" ls -la release/.github/workflows/release.yml (1)
52-52: Same silent failure concern as dev-release.yml.The
cp dist/* release/ 2>/dev/null || truepattern could hide missing artifacts in production releases, which is more critical than in dev builds.
|
/gemini review |
|
hey @jules-cli can you do a code review focusing on DX, UX, QA and Security issues? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CI/CD workflows and migrates repository references from Snider/Core to host-uk/core. The provided patches only cover changes to README.md, where all repository paths and import statements have been correctly updated to reflect the new location. These documentation changes are accurate and consistent with the repository migration. I have no specific feedback on the provided changes.
There was a problem hiding this comment.
Pull request overview
Updates the release automation to build/package across multiple platforms using host-uk/build@dev, and refreshes README references to the new GitHub org/module path.
Changes:
- Refactor
release.ymlanddev-release.ymlto use a matrix build andhost-uk/build@dev, plus simplified artifact download/merge. - Simplify release asset preparation by copying from
dist/afteractions/download-artifactwithmerge-multiple. - Update README repository URL and example import/bindings paths from
Snider/Coretohost-uk/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| README.md | Updates repository/module/bindings paths to github.com/host-uk/core. |
| .github/workflows/release.yml | Switches tagged releases to matrix builds using host-uk/build@dev and merged artifact handling. |
| .github/workflows/dev-release.yml | Switches dev releases to matrix builds using host-uk/build@dev and merged artifact handling; updates release notes block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Agent Review Responses@coderabbitai - Pin action versionAcknowledged. @copilot - mkdocs.yml referencesFixed in dd47aaf - updated @copilot - CHECKSUMS.txt merge conflictValid concern. The build action handles per-platform naming. Will verify artifacts don't collide after first successful run. @copilot / @coderabbitai - Silent failure patternAcceptable for now - the |
|
Tip For best results, initiate chat on the files or code changes.
Pin action version: Understood - using Silent failure pattern: Sounds reasonable - the All clear on my end. Good luck with the release workflow testing! 🚀 |
Trigger with @coderabbitai review to control costs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename dev-release.yml → alpha-release.yml
- Alpha builds: v0.0.4-alpha.{run_number} (prerelease)
- Add pr-build.yml for draft releases
- PR builds: v0.0.4-pr.{num}.bid.{id} (draft, not published)
- Add attestation permissions for SLSA compliance
- No more deleting/recreating dev tag
Versioning strategy:
- Draft: +pr.{NUM}.bid.{ID} (testable, not published)
- Alpha: -alpha.{N} (canary channel)
- Beta: -beta (quality scored)
- RC: -rc.{N} (release candidate)
- Stable: no suffix
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Switch from host-uk/build@dev to host-uk/build@v3
- Use dots instead of + for build metadata (GitHub tag compatible)
- v0.0.4.pr.{num}.bid.{id} format for PR drafts
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- actions/setup-go: v5 → v6 (Go 1.25+ support) - actions/upload-artifact: v4 → v6 (immutable artifacts) - actions/download-artifact: v4 → v7 (attestations support) - actions/github-script: v7 → v8 (Node 20) - actions/checkout: standardized on v6 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Testing build on local runners while GitHub hosted runners are backed up. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fall back to libwebkit2gtk-4.0-dev on older Ubuntu. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Docker self-hosted runners run as root, which can write anywhere. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Self-hosted runners need environment parity work (ARM64, root user, SDK tools). Keep self-hosted for future local-llm integration tasks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Security fix: Remove Windows drive root bypass and properly strip volume names before sandboxing. Paths like C:\Windows are now correctly sandboxed under root instead of escaping. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
host-uk/build@devactionmerge-multipleTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation