Skip to content

Improve pav make-activate command#1022

Draft
hwikle-lanl wants to merge 38 commits into
developfrom
hwikle/fix-pav-activate-paths
Draft

Improve pav make-activate command#1022
hwikle-lanl wants to merge 38 commits into
developfrom
hwikle/fix-pav-activate-paths

Conversation

@hwikle-lanl
Copy link
Copy Markdown
Collaborator

@hwikle-lanl hwikle-lanl commented Apr 7, 2026

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl self-assigned this Apr 7, 2026
@hwikle-lanl hwikle-lanl linked an issue Apr 7, 2026 that may be closed by this pull request
Don't resolve paths generated by make-activate until invocation of bash script #1018
Open
@hwikle-lanl hwikle-lanl force-pushed the hwikle/fix-pav-activate-paths branch from 78f4984 to 15751a3 Compare April 7, 2026 18:58
@hwikle-lanl hwikle-lanl marked this pull request as draft April 7, 2026 19:02
@hwikle-lanl hwikle-lanl force-pushed the hwikle/fix-pav-activate-paths branch from 36c21f5 to 76f4b93 Compare April 10, 2026 17:57
@hwikle-lanl
Improve make-activate command
9bed5b2
@hwikle-lanl
Add release note
5879809
@hwikle-lanl
Fix style issues: line too long
66694f2
@hwikle-lanl
Fix style issue: final newline
4af5d84
@hwikle-lanl
Don't use a header for scriptcomposer by default
fd60b05
@hwikle-lanl
Remove shebang from generated activate script
b85c6cb
@hwikle-lanl
Add some unit tests for make-activate
d329502
@hwikle-lanl
Add more unit tests for make-activate
98d1c95
@hwikle-lanl
Skip shellcheck test if not installed
b3e257a
@hwikle-lanl
Fix some things
832001c
@hwikle-lanl
Fix syntax errors
fa565d6
@hwikle-lanl
Fix wrong import
93c0c12
@hwikle-lanl
Add overwrite unit test for make_activate
9b97723
@hwikle-lanl
Fix a thing
673e3e0
@hwikle-lanl
Fix missing import
2a2e5d9
@hwikle-lanl
Fix shellcheck install
ff1a09f
@hwikle-lanl
Fix make-activate unit tests
f86a156
@hwikle-lanl
Fix undefined variable
cdf7cf2
@hwikle-lanl
Fix open calls
a3a6c42
@hwikle-lanl
Fix some things
38a7208
@hwikle-lanl
Add another unit test
8c49213
@hwikle-lanl
Fix another thing
8850408
@hwikle-lanl
Fix syntax error
8d644d8
@hwikle-lanl
Fix bad quotes
b548bba
@hwikle-lanl
Improve unit tests
14a0a1b
@hwikle-lanl hwikle-lanl modified the milestone: 2.7 Apr 10, 2026
@hwikle-lanl hwikle-lanl force-pushed the hwikle/fix-pav-activate-paths branch from b5a2273 to 3671a5a Compare April 10, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hwikle-lanl hwikle-lanl

Labels

None yet

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

Don't resolve paths generated by make-activate until invocation of bash script

1 participant

@hwikle-lanl