fix(log): handle invalid test/series IDs without uncaught ValueError#1072
Open
SAY-5 wants to merge 1 commit into
Open
fix(log): handle invalid test/series IDs without uncaught ValueError#1072SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review checklist:
Fixes #1064.
When
pav log <subcmd> <id>is passed an id that is neither a valid TestID nor a valid SeriesID,LogCommand.runfalls through toSeriesID(args.id), whose constructor raises an uncaughtValueErrorand crashes the CLI.This guards the conversion with
SeriesID.is_valid_idand prints a readable error before returning 1, matching how the other "load failed" paths in this command already behave. Adds a regression test.