minor fix to hospitalizations() internals#34
Open
vpnagraj wants to merge 2 commits intohrbrmstr:masterfrom
Open
minor fix to hospitalizations() internals#34vpnagraj wants to merge 2 commits intohrbrmstr:masterfrom
vpnagraj wants to merge 2 commits intohrbrmstr:masterfrom
Conversation
|
This is great - is there any way to have this function retrieve the weekly hospitalization data that is published on the weekly report? Currently it is only updating through April, 2023. |
|
I haven't tested this thoroughly, but it appears that
This might be a working fix for downloading only the FluSurv-NET data: https://github.com/philipshirk/cdcfluview/blob/master/R/hospital.r |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hrbrmstr thank you for developing and maintaining this package!
i have been using the
hospitalizations()function to retrieve FluSurv-NET data. it looks like a recent update may have had a minor bug in this function. the problem was discussed in an issue thread (#30 (comment)) ... i am putting together this PR to implement the suggestion from @IMcGovern-Seqirusthe code below should demonstrate the issue with the code currently on main branch => the fix as implemented on my fork (and incoming via this PR).
thanks again for creating this package. i am happy to make any adjustments to the PR as you see fit.
and
devtools::check()on local machine comes back clean with 0 ERRORs, 0 WARNINGs, 0 NOTEs