Skip to content

Conversation

@htrinter
Copy link
Owner

No description provided.

@htrinter htrinter requested a review from Copilot April 17, 2025 11:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces background tab loading functionality by moving the tab opening logic from the browser action UI to a background script. Key changes include adding a new background entry in the Vite config, introducing a message-based invocation of loadSites via a new background listener, and updating tests across browser action and background modules to validate the new flow.

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vite.config.ts Added background entry and custom entryFileNames configuration
src/types.ts Added type definition for communication between components
src/browseraction/components/logic/load.ts Refactored loadSites and extracted splitInputLines for clarity
src/browseraction/components/ActionBar.vue Switched from direct function call to message-based invocation
src/background.ts Introduced a new background script with a loadSites listener
Various tests files Updated tests to validate the message-based workflow
Files not reviewed (2)
  • src/manifest/chrome/manifest.json: Language not supported
  • src/manifest/firefox/manifest.json: Language not supported
Comments suppressed due to low confidence (2)

src/browseraction/tests/BrowserActionTabGroups.spec.ts:94

  • [nitpick] Consider replacing the magic number -2 with a well-named constant to improve readability and maintainability in test expectations.
selectedTabGroupId: -2,

src/browseraction/tests/BrowserAction.spec.ts:91

  • [nitpick] Consider replacing the magic number -1 with a well-named constant to clearly communicate its purpose in test expectations.
selectedTabGroupId: -1,

@htrinter htrinter changed the title Feature/bachground load Feature/background load Apr 17, 2025
@htrinter htrinter changed the title Feature/background load refactor to load tabs in background script Apr 17, 2025
@htrinter htrinter marked this pull request as ready for review April 17, 2025 14:16
@htrinter htrinter merged commit fdf1633 into develop Apr 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants