Merged
Conversation
… service-specific exceptions. @TODO-expanded testing, revised comments
…rov-metadata endpoint.
…rov-metadata endpoint.
yuanzhou
requested changes
Jan 16, 2025
Member
yuanzhou
left a comment
yuanzhou
left a comment
There was a problem hiding this comment.
@kburke in addition to the changes noted in the code comments, I'd also want you to rename the two new modules to avoid confusion. Because they are not fully tested and may not be a direct replacement of some existing logics in app.py.
entity_worker.py->dev_entity_worker.pyentity_exceptions.py->dev_entity_exceptions.py
There will be ongoing efforts to refine and test these new modules based on our priorities. For now the dev_ prefix indicates they are still in "development" phase and we don't lose your work in the meanwhile.
…g requested entity dictionary to a single property.
…-metadata. Prefix new files as dev_ until generally available for developers working on entity-api.
yuanzhou
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial release of /prov-metadata endpoint, with EntityWorker