Merged
Conversation
…g create_multiple_samples().
…_dataset_count fields for Upload.
This was referenced Mar 25, 2025
yuanzhou
requested changes
Apr 1, 2025
Member
yuanzhou
left a comment
yuanzhou
left a comment
There was a problem hiding this comment.
@kburke we'll need a bit tweaks:
-
SyntaxWarning: invalid escape sequence '\d'. I think you can either use raw stringror escape the\ -
Month validation is insufficient. 2025-13 or 2026-00 would pass the check. You may also use
datetime.strptime(yearMonth, "%Y-%m")to validate directly. I think it throws an error if the date is invalid. -
Add the new fields to OpenAPI/SmartAPI yaml, also for regenerating the SDK later.
…goryCaseValidation Add case-check to sample_category validator, and use validators durin…
… YAML, added validation that month provided is between 1 and 12.
Contributor
Author
|
Pushed changes per review requests. |
yuanzhou
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial addition of
anticipated_complete_upload_monthandanticipated_dataset_countfields forUpload.