Added new property priority_project_list and accompanying validator#867
Merged
yuanzhou merged 3 commits intodev-integratefrom May 15, 2025
Merged
Added new property priority_project_list and accompanying validator#867yuanzhou merged 3 commits intodev-integratefrom
yuanzhou merged 3 commits intodev-integratefrom
Conversation
…e sensitive. updated entity-api-spec to include this new field as well as rui_exemption
yuanzhou
requested changes
May 15, 2025
src/schema/provenance_schema.yaml
Outdated
| required: false | ||
| indexted: false | ||
| description: The list of priority projects that this Dataset data will be used For | ||
| mutable: true |
Member
There was a problem hiding this comment.
I don't think we have this mutable property, only immutable.
Contributor
Author
There was a problem hiding this comment.
Good catch. I was copying from the details in the card and forgot its immutable not mutable. Fixed this and reversed them (immutable = false rather than mutable = true)
| - validate_in_admin_group | ||
| before_property_update_validators: | ||
| - validate_in_admin_group | ||
| priority_project_list: |
Member
There was a problem hiding this comment.
Because Publication inherits Dataset properties, we'll need to explicitly specify this new field and mark it with null to exclude from Publication.
Contributor
Author
There was a problem hiding this comment.
Yep, good catch. Fixed
…f immutable. Also removed priority_project_list from publication
yuanzhou
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.