Revisions to support 'reindex' URL parameter#908
Merged
yuanzhou merged 5 commits intodev-integratefrom Sep 9, 2025
Merged
Conversation
…t-uploads Yuanzhou/debug bulk edit uploads
…creation, entity modification, and multi-component creation for #907
yuanzhou
requested changes
Sep 9, 2025
src/app.py
Outdated
| try: | ||
| supress_reindex = _suppress_reindex() | ||
| except Exception as e: | ||
| return http_bad_request(e) |
Member
There was a problem hiding this comment.
Change to use bad_request_error() (without return) to be consistent with all the other usages.
http_bad_request() was originally registered as Flask error handler with decorator when we used older version of Flask. We may remove them.
src/app.py
Outdated
| try: | ||
| suppress_reindex = _suppress_reindex() | ||
| except Exception as e: | ||
| return http_bad_request(e) |
Member
There was a problem hiding this comment.
Same as the previous comment. Change to use bad_request_error() (without return) to be consistent with all the other usages.
| elif reindex_str == 'true': | ||
| return False | ||
| raise Exception(f"The value of the 'reindex' parameter must be True or False." | ||
| f" '{request.args.get('reindex')}' is not recognized.") |
Member
There was a problem hiding this comment.
Can we also explicitly specify that the value is case-insensitive in the log message? Saying must be True or False is only one case.
yuanzhou
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revisions to support 'reindex' URL parameter on endpoints for entity creation, entity modification, and multi-component creation for #907