ORCID: Added a guard before rendering the OAuth buttons#1875
Merged
Conversation
Contributor
Author
|
config/config.xml is not included in this pull request because: |
0e6a57e to
4217a24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket https://nanohub.org/support/ticket/505173
Two changes made:
config/config.xml — Changed orcid_service default from "public" to "members". The XML default was "public" but every PHP code path uses 'members' as its
fallback, so if an admin ever saved the config page without explicitly choosing a service it would store "public" — and there's no orcid_public_client_id
field, making $clientID permanently empty.
models/fields/orcid.php — Added an $oauthConfigured guard before rendering the OAuth buttons:
$oauthConfigured = ($srv !== 'public' && !empty($clientID) && !empty($redirectURI));
The "Create or Connect" and "Grant Permission" buttons now only appear when:
This prevents users from clicking a broken link that ORCID rejects. Until the admin configures orcid_members_client_id and orcid_members_redirect_uri in
Administrator → Components → Members → Options, the buttons will simply not appear.