Skip to content

refactor wan vace pipeline tests to the new mixin structure#14231

Merged
sayakpaul merged 2 commits into
huggingface:mainfrom
akshan-main:refactor-wan-vace-pipeline-tests
Jul 20, 2026
Merged

refactor wan vace pipeline tests to the new mixin structure#14231
sayakpaul merged 2 commits into
huggingface:mainfrom
akshan-main:refactor-wan-vace-pipeline-tests

Conversation

@akshan-main

Copy link
Copy Markdown
Contributor

What does this PR do?

Refactors the wan VACE pipeline tests to the new mixin structure from #14113: a WanVACEPipelineTesterConfig plus TestWanVACEPipeline(PipelineTesterMixin) and TestWanVACEPipelineMemory(MemoryTesterMixin).

Existing coverage is kept: test_inference, the single and multiple reference-image variants, the two-transformer variants, and test_save_load_optional_components. The two batch tests stay skipped because WanVACEPipeline does not support batched prompts (it raises on a list of prompts). No caching tests are added since the old suite had none, and the attention-slicing test is dropped as the new framework has no equivalent.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you read our philosophy doc (important for complex PRs)?
  • Was this discussed/approved via a GitHub issue or the forum? Discussed on Slack with @sayakpaul
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@sayakpaul

@github-actions github-actions Bot added size/L PR with diff > 200 LOC tests and removed size/L PR with diff > 200 LOC labels Jul 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @akshan-main, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.

@github-actions github-actions Bot added the size/L PR with diff > 200 LOC label Jul 20, 2026

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayakpaul
sayakpaul merged commit cee630d into huggingface:main Jul 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants