Open
Conversation
danieldk
reviewed
Mar 5, 2026
Member
danieldk
left a comment
There was a problem hiding this comment.
Really cool work! Added a comment about the submodules.
| run: | | ||
| KERNEL="${{ steps.validate.outputs.kernel }}" | ||
| ( cd "$KERNEL" && nix run -L .#build-and-upload ) | ||
| ( cd "$KERNEL" && nix run -L .?submodules=1#build-and-upload ) |
Member
There was a problem hiding this comment.
I think we should put this in the flake itself: https://discourse.nixos.org/t/nix-2-27-0-released/62003
If users build a kernel manually they'll miss the ?submodules=1.
Collaborator
Author
There was a problem hiding this comment.
oo thanks for the tip, this is much cleaner. I fully agree its better to declare this in the flake than depend on users to include ?submodules=1 when building. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the deep-gemm kernels and relies on an experimental feature added in this PR huggingface/kernels#298
The deep-gemm kernels heavily rely on JIT compilation and need access to nvcc, cutlass headers and internal deep-gemm headers at runtime. This pr includes the internal headers and minor changes to lazily load nvrtc at runtime, and the related PR in the kernels builder updates the build process to inject cutlass headers into the build artifacts so the kernel has all of the required dependencies at runtime.
example usage
note
CUDA_HOME=/usr/local/cuda-12.9 uv run scripts/readme_example.py