Export optimum.__version__ without breaking the namespace package - #2480
Open
adi-IL wants to merge 1 commit into
Open
Export optimum.__version__ without breaking the namespace package#2480adi-IL wants to merge 1 commit into
adi-IL wants to merge 1 commit into
Conversation
import optimum currently has no __version__ because the top-level package is a namespace (no __init__.py). Add a thin __init__ that re-exports version and uses pkgutil.extend_path so split installs like optimum-onnx still resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2188
import optimum; print(optimum.__version__)currently raisesAttributeError. The version string already lives inoptimum/version.py. It was never re-exported at the package root because this tree is a namespace package (no__init__.py), which is howoptimum-onnxandoptimum-intelattach themselves.#2406 added a bare
__init__.pyand went stale. A bare init would turnoptimuminto a regular package and drop other install paths from__path__.This PR adds a thin
__init__.pythat:__version__fromoptimum.version.pkgutil.extend_pathso split installs still resolve.Check
prints
2.4.0.dev0. Existingfrom optimum.version import __version__is unchanged.Added
tests/common/test_version.pyfor the attribute and that__path__stays searchable.Claimed with
#takeon #2188: #2188 (comment)