Fix picker highlight text contrast#404
Merged
Merged
Conversation
alejandro-ao
marked this pull request as ready for review
July 18, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix picker selection styling so focused labels use each active theme's configured highlight foreground and background colors.
This corrects the Textual highlight class selector from
.--highlightto.-highlightand adds sufficiently specific rules for picker labels whose normal text-color selectors would otherwise win the cascade. The fix covers the theme, model, login-method, and login-provider pickers. A parameterized regression test verifies the theme picker against all three built-in themes.User experience
Focused theme names are now legible in dark mode: Tau renders dark text over the light aqua selection background instead of white text with insufficient contrast. Picker selections also consistently follow the shared theme palette across built-in themes.
Closes #401.
Manual validation
tau-darktheme./theme.tau-lightandhigh-contrast, reopen/theme, and confirm each focused row uses that theme's configured selection colors.Checks
uv run pytestuv run ruff check .uv run ruff format --check .uv run mypyuv buildhugo --minify(fromwebsite/)