[WIP] FIX Make Mixtral LoRA loading work#44478
Open
BenjaminBossan wants to merge 6 commits intohuggingface:mainfrom
Open
[WIP] FIX Make Mixtral LoRA loading work#44478BenjaminBossan wants to merge 6 commits intohuggingface:mainfrom
BenjaminBossan wants to merge 6 commits intohuggingface:mainfrom
Conversation
Required fixes: - some code was using unordered data structures, making weight order random - adjust alpha to offset increased rank from fusion - import functions from PEFT if available
This can be used in PEFT to apply weight conversion there without having to either re-implement the whole weight conversion machinery or having to call transformer_model.load_adapter. We want to avoid the latter because there is a lot of PEFT custom logic to weight loading which would require adjusting for that case.
Member
Author
|
Note: The added test is a |
mark stuff that can be removed with peft 0.19
…san/transformers into peft-weight-conversion-fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required fixes:
See huggingface/peft#3083.