Skip to content

Fix training ci and clean some tests#44491

Open
SunMarc wants to merge 1 commit intomainfrom
fix-ci-training
Open

Fix training ci and clean some tests#44491
SunMarc wants to merge 1 commit intomainfrom
fix-ci-training

Conversation

@SunMarc
Copy link
Member

@SunMarc SunMarc commented Mar 6, 2026

What does this PR do?

Since I removed some folders (fsdp, deepspeed) related to training, I need to modify the workflows !

Comment on lines +159 to +168
# Map short names to actual test paths for trainer/distributed tests
test_path="tests/${model}"
if [ "$model" = "fsdp" ]; then
test_path="tests/trainer/distributed/test_trainer_distributed_fsdp.py"
elif [ "$model" = "ddp" ]; then
test_path="tests/trainer/distributed/test_trainer_distributed_ddp.py"
elif [ "$model" = "trainer" ] && [ "$report_name_prefix" = "run_trainer_and_fsdp_gpu" ]; then
test_path="tests/trainer --ignore=tests/trainer/distributed"
fi
script -q -c "PATCH_TESTING_METHODS_TO_COLLECT_OUTPUTS=yes _PATCHED_TESTING_METHODS_OUTPUT_DIR=/transformers/reports/${machine_type}_${report_name_prefix}_${matrix_folders}_test_reports python3 -m pytest -rsfE -v -m '${pytest_marker}' --make-reports=${machine_type}_${report_name_prefix}_${matrix_folders}_test_reports ${test_path}" test_outputs.txt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it fine @ydshieh ?

@SunMarc SunMarc requested a review from ydshieh March 6, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant