Skip to content

Fix wrong (non-existing) checkpoints#44549

Open
ydshieh wants to merge 1 commit intomainfrom
fix_doc_ckpt
Open

Fix wrong (non-existing) checkpoints#44549
ydshieh wants to merge 1 commit intomainfrom
fix_doc_ckpt

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Mar 9, 2026

What does this PR do?

The previous values are simply wrong.

(which also cause problems for tiny model creation)

@ydshieh ydshieh requested review from ArthurZucker and vasqu March 9, 2026 15:45
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: apertus, chameleon, dab_detr, edgetam, edgetam_video, falcon_h1, gemma3, glm4_moe, glm4_moe_lite, helium, instructblip, instructblipvideo, lighton_ocr, llava, mixtral, nemotron

@ydshieh
Copy link
Collaborator Author

ydshieh commented Mar 9, 2026

apparently there are some more places to update (to make modular check works)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Mar 9, 2026

It looks like the modular is creating

Salesforce/instructblipvideo-flan-t5-xl

based on the block

@auto_docstring(checkpoint="Salesforce/instructblip-flan-t5-xl")
class InstructBlipVideoVisionConfig(InstructBlipVisionConfig):
    pass

and complain it doesn't match the actual one that should be used

Salesforce/instructblip-flan-t5-xl

@vasqu @Cyrilvallez

Is the only way is just to remove the following 2 blocks from modular file

@auto_docstring(checkpoint="Salesforce/instructblip-flan-t5-xl")
class InstructBlipVideoVisionConfig(InstructBlipVisionConfig):
    pass


@auto_docstring(checkpoint="Salesforce/instructblip-flan-t5-xl")
class InstructBlipVideoQFormerConfig(InstructBlipQFormerConfig):
    pass

??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants