Fix image-text-to-text stop_sequence handling#47032
Open
Sunt-ing wants to merge 1 commit into
Open
Conversation
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ImageTextToTextPipelineacceptsstop_sequence, but the stop-sequence branch writes intogenerate_kwargseven when the user did not pass agenerate_kwargsdict. A normal pipeline call such aspipe(image, text=..., stop_sequence=".")fails before generation with:This creates the forward
generate_kwargswhen needed and passes stop sequences through generation'sstop_stringssupport, matching the any-to-any pipeline path. This also avoids forcing an extraeos_token_idinto image-text model wrappers that already provide their own decoder EOS value.Repro and output
Tests
Code Agent Policy
Before submitting
Pull Request checks?
to it if that's the case.
Who can review?
cc @zucchini-nlp @Rocketknight1