combine .atacCompartments and arrayCompartments workers into getCompartments#104
Open
jamespeapen wants to merge 6 commits intohuishenlab:masterfrom
Open
combine .atacCompartments and arrayCompartments workers into getCompartments#104jamespeapen wants to merge 6 commits intohuishenlab:masterfrom
jamespeapen wants to merge 6 commits intohuishenlab:masterfrom
Conversation
5244f45 to
10f29ec
Compare
10f29ec to
8ed235e
Compare
8ed235e to
05cb1b0
Compare
493bd1a to
9382e7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getATACABSignalandgetArrayABsignalhad much of the same logic. Now with theassayargument, they can be called fromscCompartmentsorgetArrayComparmentsarrayCompartments.getATACABSignalis no longer necessary asscCompartmentscan callgetCompartmentsdirectly.For functionality and consistency the
boot.parallelandboot.coresargs have been added toscCompartmentsand reorganized into groups relating to parallelization and/or bootstrapping.getArrayCompartmentsis nowarrayCompartmentsto be consistent withscCompartments.