Always return a RaggedExperiment from fixCompartments#121
Open
jamespeapen wants to merge 2 commits intohuishenlab:masterfrom
Open
Always return a RaggedExperiment from fixCompartments#121jamespeapen wants to merge 2 commits intohuishenlab:masterfrom
jamespeapen wants to merge 2 commits intohuishenlab:masterfrom
Conversation
…riment So that the functions are pure for Bioc requirements and so if a RaggedExperiment is provided, its also returned for S7 compatibility - make scCompartmapCall from both fixed and non-fixed `scCompartments` results.
jamespeapen
force-pushed
the
fixCompartments
branch
from
995da83 to
a0fd2d7
Compare
Collaborator
|
Beginning the review to get this merged quickly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that the functions are pure for Bioc requirements. Also if a RaggedExperiment is provided, its also returned for S7 compatibility - make scCompartmapCall from both fixed and non-fixed
scCompartmentsresults.