Don't depend on OpenSSL for base64 decode#1
Open
dsommers wants to merge 1 commit intohuiyiqun:masterfrom
Open
Conversation
Took most of the simpler base64 decode in libbase64 [1] instead of depending on a large external library. Also revamped lots of the check_auth() code to be more failsafe, removed a few memory leaks. And the hashmap_return_entry() function didn't NULL-terminate the value, so added that as well. [1] <https://github.com/kisom/libbase64/blob/master/src/base64.c>
Author
|
If this base64 implementation is too heavy, we can consider another one from the OpenVPN source repository as well. https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/base64.c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took most of the simpler base64 decode in libbase64 [1] instead of
depending on a large external library.
Also revamped lots of the check_auth() code to be more failsafe, removed
a few memory leaks. And the hashmap_return_entry() function didn't
NULL-terminate the value, so added that as well.
[1] https://github.com/kisom/libbase64/blob/master/src/base64.c