Skip to content

Conversation

@dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented Mar 24, 2025

try-runtime checks at ci throw error now called Result::unwrap() on an Err value: Other("this migration can be deleted") after executed runtime upgrade at mainnet to 127 due to https://github.com/humanode-network/substrate/blob/8afcafd721d31939e4dee7b779f152ab9eb1c8be/frame/multisig/src/migrations.rs#L49

#1498 has faced this error. So, probably, we should remove it now.

Btw, I don't think that pallet_multisig::migrations should throw error for this logic at pre_upgrade implementation.

@dmitrylavrenov dmitrylavrenov changed the title Remove already applied pallet_multisig::migrations::v1::MigrateToV1 migration Remove already applied pallet_multisig::migrations::v1::MigrateToV1 at humanode-runtime migrations scope Mar 24, 2025
@MOZGIII
Copy link
Contributor

MOZGIII commented Mar 24, 2025

This is actually interesting, and finally forces some pattern on the migrations management: remove them as soon as they're no longer useful.
This leads to some a set of complications and new things we have to keep an account for. Let's create an issue to discuss and think this through.

@dmitrylavrenov
Copy link
Contributor Author

dmitrylavrenov commented Mar 24, 2025

This is actually interesting, and finally forces some pattern on the migrations management: remove them as soon as they're no longer useful. This leads to some a set of complications and new things we have to keep an account for. Let's create an issue to discuss and think this through.

Yep, that's why the following rework was introduced - #1315 to unify the whole migrations scope.

@dmitrylavrenov
Copy link
Contributor Author

This is actually interesting, and finally forces some pattern on the migrations management: remove them as soon as they're no longer useful. This leads to some a set of complications and new things we have to keep an account for. Let's create an issue to discuss and think this through.

#1500

@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit 472bb92 Mar 24, 2025
21 checks passed
@dmitrylavrenov dmitrylavrenov deleted the remove-done-multisig-migration branch March 24, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants