Skip to content

Conversation

@MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Oct 7, 2025

This is a continuation of #1617. Here we integrate the fixed validators set with the humanode session, humanode offences, runtime, peer and etc.

Feel free to note what's needed to be done here with regard to Q/A - like more tests or benches.

The intended design:

  • we can have bootnodes, bioauth and fixed set validators at the same time; in practice we won't ever use fixed validators set unless there is an emergency and we anticipate the bioauth list will go empty
  • thus the system should correctly handle validator address duplicates from the bioauth to fixed set auth; bioauth should take precedence where we much choose one or the other in the code (since the fixed validator set in a backup)
  • we can ban an unban validators from the fixed set (unlike bootnodes)
  • we can't slash the validators at the fixed set for being offline; this is due to the nature of the idea why we add this in the first place - to cover for the short-term emergencies, and because this is also to simplify the current design - we could technically support temporarily taking validators offline due to being offline and automatically re-enable them in a bit of time to help with possible finality issues

@MOZGIII MOZGIII force-pushed the integrate-fixed-validators-set branch from 9963ac7 to bc864c6 Compare October 7, 2025 05:15
@MOZGIII MOZGIII force-pushed the frozen-validator-set branch from 5fa9eb4 to 88f4b90 Compare October 7, 2025 05:43
@MOZGIII MOZGIII force-pushed the integrate-fixed-validators-set branch 5 times, most recently from a3f2faa to 319084c Compare October 7, 2025 06:43
@MOZGIII MOZGIII force-pushed the integrate-fixed-validators-set branch from 319084c to a15fec9 Compare October 7, 2025 06:48
@MOZGIII MOZGIII force-pushed the frozen-validator-set branch from 88f4b90 to 040c810 Compare October 7, 2025 06:59
@MOZGIII MOZGIII marked this pull request as ready for review October 7, 2025 09:22
@MOZGIII MOZGIII force-pushed the integrate-fixed-validators-set branch from a15fec9 to 57d1447 Compare October 7, 2025 15:40
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Oct 7, 2025

I have updated the PR description with some notes on the intent for this change.

Also, I'm tempted to postpone the complete testing coverage of this feature for a less urgent moment; please give me your opinion on what it critical to test in this high-urgency timing, and what we could test later.

I, for one, think we should add tests to see to it that the pallet-session handles the potential duplicates coming from the pallet-humanode-session correctly. Where should we put it? At the runtime level or at the pallet-humanode-session? I think pallet-humanode-session is a good fit for this.

Base automatically changed from frozen-validator-set to master October 7, 2025 15:57
@MOZGIII MOZGIII force-pushed the integrate-fixed-validators-set branch from b780da5 to cc5f24c Compare October 7, 2025 20:11
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Oct 7, 2025

I've added the test I wanted and it turns out there is an issue there!

I've decided to provide a separate PR for the fix: #1621
Please take a look

@MOZGIII MOZGIII force-pushed the integrate-fixed-validators-set branch from 324db2b to 753c3d0 Compare November 14, 2025 07:31
MOZGIII and others added 6 commits December 4, 2025 18:01
…est (#1620)

Add more checks to verify slashin logic at a corresponding runtime test
* Add dedupe utils

* Implement validator deduplication based on account id and the first-in order

* Fix the doc comment on the DedupeKeyExtractor::Output

* Fixed doc comment on DedupeIter::dedupe_key_extractor

* Apply suggestion from @dmitrylavrenov

Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>

* Add a test

* Remove the broken impl (doesn't work either way)

---------

Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
@MOZGIII MOZGIII force-pushed the integrate-fixed-validators-set branch from 753c3d0 to b4369af Compare December 4, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants