Skip to content

Conversation

@Gero1999
Copy link
Contributor

@Gero1999 Gero1999 commented Dec 6, 2024

Proposed in #340

This is a potential solution for the opened topic in case you agree with any of the feat requests. There are two features associated with the commits in this PR:

  • Add before.tmax & after.tmax in conc.blq list argument. In NCA is very typical to use tmax as a reference on how to deal with BLQ data. I changed PKNCA clean.conc.blq to include for the list definition "before.tmax" and "after.tmax" using the same logic as with pk.calc.tfirst but with pk.calc.tmax.

  • Default keep values in conc.blq list argument . I feel that when a user does not define a specific scenario in the list argument (i.e, middle) they simply don't want to perform any action. For that reason, I modified PKNCA.options to put keep as the default value for list elements missing.

Feel free to give it a look, change or ignore/delete it!

@billdenney
Copy link
Member

billdenney commented Dec 9, 2024

With a first read-through, the code looks good to me. Can you please:

  1. Resolve the failing tests (row numbering can be resolved by setting data.frame row names to NULL within the function, I don't think that they are important).
  2. Add tests for the new code. Please ensure that every line and every logical condition is tested.
  3. Add the change to the News file

I may have additional comments after these. The above changes will make it easier to review everything and will be needed before merging.

@Gero1999
Copy link
Contributor Author

Gero1999 commented Dec 9, 2024

Hello @billdenney I am not sure about what you meant in 1. with the row numbering and the data.frame names, but in principle I tried to solve all issues and implement new tests, so I hope it is fine!

@billdenney billdenney marked this pull request as ready for review December 11, 2024 03:01
@billdenney billdenney marked this pull request as draft December 11, 2024 03:01
@Gero1999 Gero1999 changed the title clean.conc.blq: feats for tmax reference and default keep clean.conc.blq: feats for tmax reference Dec 11, 2024
@Gero1999 Gero1999 marked this pull request as ready for review December 11, 2024 12:18
@billdenney
Copy link
Member

With my comment 1, when I was looking at the test errors, there appeared to be row number difference issues (which shouldn't matter). I will take a more careful look now and likely merge soon.

@billdenney
Copy link
Member

Looks good! Thanks!

@billdenney billdenney merged commit 2cb48c1 into humanpred:main Dec 13, 2024
6 checks passed
@billdenney billdenney mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants