-
Notifications
You must be signed in to change notification settings - Fork 29
clean.conc.blq: feats for tmax reference #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
With a first read-through, the code looks good to me. Can you please:
I may have additional comments after these. The above changes will make it easier to review everything and will be needed before merging. |
|
Hello @billdenney I am not sure about what you meant in 1. with the row numbering and the data.frame names, but in principle I tried to solve all issues and implement new tests, so I hope it is fine! |
|
With my comment 1, when I was looking at the test errors, there appeared to be row number difference issues (which shouldn't matter). I will take a more careful look now and likely merge soon. |
|
Looks good! Thanks! |
Proposed in #340
This is a potential solution for the opened topic in case you agree with any of the feat requests. There are two features associated with the commits in this PR:
Add before.tmax & after.tmax in conc.blq list argument. In NCA is very typical to use tmax as a reference on how to deal with BLQ data. I changed PKNCA clean.conc.blq to include for the list definition "before.tmax" and "after.tmax" using the same logic as with
pk.calc.tfirstbut withpk.calc.tmax.Default keep values in conc.blq list argument . I feel that when a user does not define a specific scenario in the list argument (i.e, middle) they simply don't want to perform any action. For that reason, I modified PKNCA.options to put keep as the default value for list elements missing.
Feel free to give it a look, change or ignore/delete it!