Feature request: New logslope & c1 impute_start methods #350 #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PKNCA_method_start functions that could perhaps be default/standard. Feel free to give them a look and merge them if they are useful!
Closes #350
Left problems to review:
Desired behavior of these functions under NA (time or conc) or conc 0 circumstances. Perhaps also to be considered for Test all imputation methods for all concentrations are NA, all times are NA, all concentrations are 0 #361, as other functions are currently inconsistent. When missing start concentration if:Let me know if this behaviors are the expected, if not which one you think it should be!
Use of pk.calc.c0.method.c1 and the need to assert time. Check this conversation