fix PKNCAconc: exclude before timecheck #468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billdenney
requested changes
Sep 12, 2025
Member
billdenney
left a comment
billdenney
left a comment
There was a problem hiding this comment.
Can you please do the same for PKNCAdose?
Please also merge in the current main branch.
Contributor
Author
Hey sorry @billdenney I did not manage to find where in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the concentration-time validation in
PKNCAconc.data.frameso that excluded points (as indicated by theexcludecolumn) are not considered during checks. Added a test to verify itt intest-PKNCAconcerrors are not produced.Closes #310