Skip to content

Conversation

@PavanLomati
Copy link
Contributor

…A integration functions

- humanpred#493: Removed aumc_integrate() function and simplified its use by calling auc_integrate() with appropriate fun_linear, fun_log, and fun_inf arguments.
- humanpred#494: Refactored pk.calc.aucint() and pk.calc.aumcint():
    - Renamed pk.calc.aucint() to pk.calc.auxcint() with integration functions passed as arguments.
    - Created new, simpler pk.calc.aucint() and pk.calc.aumcint() that call pk.calc.auxcint() with correct integration functions.
- humanpred#495: Applied same refactoring to pk.calc.auciv() and pk.calc.aumciv() functions.
- Updated NEWS.md with these changes.
@PavanLomati PavanLomati closed this Dec 4, 2025
@PavanLomati PavanLomati reopened this Dec 4, 2025
Copy link
Member

@billdenney billdenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update. Please also add this and the prior changes to NEWS.md and rebuild the documentation with devtools::document().

conc.blq=NULL,
conc.na=NULL,
check=TRUE,
...,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-add the ... argument. It helps absorb some extraneous arguments which occasionally come through.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ... argument to pk.calc.auxcint and pk.calc.auxc

…escribeIn for pk.calc.auxciv and pk.calc.auxcint. Updated NEWS.Rmd.

Updating PKNCA documentation
ℹ Loading PKNCA
✖ In topic 'pk.calc.aucint.Rd': Skipping; no name and/or title.
✖ In topic 'pk.calc.aumcint.Rd': Skipping; no name and/or title.
✖ In topic 'pk.calc.auciv.Rd': Skipping; no name and/or title.
@PavanLomati
Copy link
Contributor Author

Added ... argument to pk.calc.auxcint and pk.calc.auxc. Updated #' @describeIn for pk.calc.auxciv and pk.calc.auxcint. Updated NEWS.Rmd.
Updating PKNCA documentation
ℹ Loading PKNCA
✖ In topic 'pk.calc.aucint.Rd': Skipping; no name and/or title.
✖ In topic 'pk.calc.aumcint.Rd': Skipping; no name and/or title.
✖ In topic 'pk.calc.auciv.Rd': Skipping; no name and/or title.

@billdenney
Copy link
Member

The testing indicates only 67% of the patch has tests associated with it. Please add tests so that the patch has 100% coverage.

You can see the missed lines for code coverage by

  1. clicking on the "codecov/patch" link above
  2. Clicking "view this pull request on codecov"
  3. Click on the "file explorer" tab
  4. Navigate through the R directory and files to find places where you added code that do not have a test
  5. Add the test in the "tests/testthat/test-[filename].R" where "[filename]" is the same as the filename with the R code. (If you have the file open in your R session, you can use usethis::use_test() and choose not to overwrite the test file, and it will open for you in Rstudio.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants