-
Notifications
You must be signed in to change notification settings - Fork 29
Fixes issues #493, #494, #495: Refactor NCA integration functions #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixes issues #493, #494, #495: Refactor NCA integration functions #497
Conversation
…A integration functions - humanpred#493: Removed aumc_integrate() function and simplified its use by calling auc_integrate() with appropriate fun_linear, fun_log, and fun_inf arguments. - humanpred#494: Refactored pk.calc.aucint() and pk.calc.aumcint(): - Renamed pk.calc.aucint() to pk.calc.auxcint() with integration functions passed as arguments. - Created new, simpler pk.calc.aucint() and pk.calc.aumcint() that call pk.calc.auxcint() with correct integration functions. - humanpred#495: Applied same refactoring to pk.calc.auciv() and pk.calc.aumciv() functions. - Updated NEWS.md with these changes.
billdenney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this update. Please also add this and the prior changes to NEWS.md and rebuild the documentation with devtools::document().
| conc.blq=NULL, | ||
| conc.na=NULL, | ||
| check=TRUE, | ||
| ..., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-add the ... argument. It helps absorb some extraneous arguments which occasionally come through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added ... argument to pk.calc.auxcint and pk.calc.auxc
…escribeIn for pk.calc.auxciv and pk.calc.auxcint. Updated NEWS.Rmd. Updating PKNCA documentation ℹ Loading PKNCA ✖ In topic 'pk.calc.aucint.Rd': Skipping; no name and/or title. ✖ In topic 'pk.calc.aumcint.Rd': Skipping; no name and/or title. ✖ In topic 'pk.calc.auciv.Rd': Skipping; no name and/or title.
|
Added ... argument to pk.calc.auxcint and pk.calc.auxc. Updated #' @describeIn for pk.calc.auxciv and pk.calc.auxcint. Updated NEWS.Rmd. |
|
The testing indicates only 67% of the patch has tests associated with it. Please add tests so that the patch has 100% coverage. You can see the missed lines for code coverage by
|
aumc_integratefunction #493: Removed aumc_integrate() function and simplified its use by calling auc_integrate() with appropriate fun_linear, fun_log, and fun_inf arguments.pk.calc.aucint()topk.calc.auxcint()and generalize its use for AUC or AUMC #494: Refactored pk.calc.aucint() and pk.calc.aumcint():pk.calc.auciv()topk.calc.auxciv()and generalize its use #495: Applied same refactoring to pk.calc.auciv() and pk.calc.aumciv() functions.